deleteCallback to delete different versions of a file

[jorisvaesen]

Ref #453

I'll add an example to the docs if this feature gets approved.

[davidyell]

I would actually specify 'Entity' instead of 'object' here, just to be clearer.

[jorisvaesen]

Indeed.

[davidyell]

My personal preference would be null here to demonstrate a 'nothing' value, rather than a boolean.

[jorisvaesen]

Just saw nameCallback also uses null as default, will change this accordingly.

[davidyell]

Not sure about committing comments to the repo, but the repo code style will be up to @josegonzalez

[jorisvaesen]

Hmm, it's just because I copied code from https://github.com/FriendsOfCake/cakephp-upload/blob/master/tests/TestCase/Model/Behavior/UploadBehaviorTest.php#L415
Will delete the comments.

[davidyell]

Might not be a big deal as it's in a test. Although I do wonder if you have to comment each assert, does that mean they could be different test cases? Just a thought.

[davidyell]

I would also probably throw in a test case for when deleteCallback is false or null just to ensure it's not executed, which might help prevent future regressions.

Otherwise, reading the code, it seems okay to me. Perhaps just a quick check with PHPCS if you've not already done that.

[josegonzalez]

Seems fine, needs an example.

[saeideng]

nice return

                     return [
                            $path . $entity->{$field},
                           $path . 'thumbnail-' . $entity->{$field}
                       ];

good job 👍