-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for CakePHP 3.6 #485
Prepare for CakePHP 3.6 #485
Conversation
Dropping php5.5 seems reasonable. |
6dece51
to
5e9d8cb
Compare
This should be ready to merge |
@@ -60,7 +60,7 @@ public function beforeMarshal(Event $event, ArrayObject $data, ArrayObject $opti | |||
{ | |||
$validator = $this->_table->validator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be getValidator
cc8e9bf
to
ff684ab
Compare
Done. What else should be done ? |
Seems reasonable. Can you smoke-test this in an app and verify everything works as you expect? |
c145ba9
to
66b7630
Compare
As of now, Upload works. The code I used is based of the examples. KeepFilesOnDelete set false also works $this->addBehavior('Josegonzalez/Upload.Upload', [
'foto' => [
'path' => 'webroot{DS}img{DS}uploads{DS}tickets{DS}{field-value:ticket_id}{DS}',
'nameCallback' => function ($data, $settings) {
return time() . '_' . $data['name'];
},
],
]);
// ....
$validator->setProvider('upload', UploadValidation::class);
$validator->add('foto', 'fileFileUpload', [
'rule' => 'isFileUpload',
'message' => 'Debe cargar una foto',
'provider' => 'upload',
'on' => 'create',
]); |
Hey all! Any ETA on when is this going to be released? Thanks! |
Now seems fine. |
Released 4.0.0. |
FYI: It says in the release that Cake 3.6 is required ("This change requires at least CakePHP 3.6, and should support the upcoming 4.x release.") But it only seems to require Cake 3.4 in the |
Update code to remove deprecations.
Maybe I should drop PHP 5.5 ?