upgrade to CakePHP 5

[arusinowski]

Hi, this is cakephp upload plugin updated to CakePHP 5 dev version. I will update this branch as new versions of CakePHP5 become available.

[ADmad]

To get the testsuite running you'll also need to update the phpunit config and the tests bootstrap to use the new fixture schema loading. You can refer to the cake-5 of the search plugin for the same.

[codecov]

Codecov Report

Patch coverage: 92.10% and project coverage change: -0.02 ⚠️

Comparison is base (820a45c) 95.87% compared to head (5345747) 95.86%.

Additional details and impacted files

@@             Coverage Diff              @@
##             cake-5     #593      +/-   ##
============================================
- Coverage     95.87%   95.86%   -0.02%     
  Complexity      109      109              
============================================
  Files            11       11              
  Lines           291      290       -1     
============================================
- Hits            279      278       -1     
  Misses           12       12              

Impacted Files	Coverage Δ
src/File/Transformer/DefaultTransformer.php	100.00% <ø> (ø)
src/UploadPlugin.php	0.00% <ø> (ø)
src/Database/Type/FileType.php	33.33% <33.33%> (ø)
src/Model/Behavior/UploadBehavior.php	95.04% <88.88%> (+0.04%)	⬆️
src/File/Path/Basepath/DefaultTrait.php	100.00% <100.00%> (ø)
src/File/Path/DefaultProcessor.php	100.00% <100.00%> (ø)
src/File/Path/Filename/DefaultTrait.php	92.30% <100.00%> (+6.59%)	⬆️
src/File/Writer/DefaultWriter.php	100.00% <100.00%> (ø)
src/Validation/Traits/ImageValidationTrait.php	100.00% <100.00%> (ø)
src/Validation/Traits/UploadValidationTrait.php	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[LordSimal]

@arusinowski we recently released CakePHP 5.0 RC1 which also included a major PHPUnit update from 9 to 10.
Do you want to continue/finish this PR?

[arusinowski]

@arusinowski we recently released CakePHP 5.0 RC1 which also included a major PHPUnit update from 9 to 10. Do you want to continue/finish this PR?

Yes, i already started working on tests upgrade

[LordSimal]

FYI: The new Cake5 CI workflow doesn't require having phpstan and psalm in the composer.json anymore.
instead all you have to do is add this file to the repo (inside the .phive folder of course)
Then github CI can check stan as well.

You can also adjust the composer.json scripts section to contain the additional commands like you can see here:
https://github.com/cakephp/debug_kit/blob/5.x/composer.json#L54-L62
Then you can check stan locally as well.