Merge pull request #559 from carusogabriel/refactoring-tests

Refactoring tests
FriendsOfCake · Dec 5, 2017 · a26078b · a26078b
2 parents 1a2937c + 718b3c1
commit a26078b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/tests/TestCase/Error/ExceptionRendererTest.php b/tests/TestCase/Error/ExceptionRendererTest.php
@@ -45,7 +45,7 @@ public function testNormalExceptionRendering()
 
         $viewVars = $Controller->viewVars;
 
-        $this->assertTrue(!empty($viewVars['_serialize']));
+        $this->assertNotEmpty($viewVars['_serialize']);
 
         $expected = ['success', 'data'];
         $actual = $viewVars['_serialize'];
@@ -121,7 +121,7 @@ public function testNormalExceptionRenderingQueryLog()
 
         $viewVars = $Controller->viewVars;
 
-        $this->assertTrue(!empty($viewVars['_serialize']));
+        $this->assertNotEmpty($viewVars['_serialize']);
 
         $expected = ['success', 'data', 'queryLog'];
         $actual = $viewVars['_serialize'];
@@ -144,7 +144,7 @@ public function testNormalExceptionRenderingQueryLog()
         unset($actual['trace'], $actual['file'], $actual['line']);
         $this->assertEquals($expected, $actual);
 
-        $this->assertTrue(!empty($queryLog));
+        $this->assertNotEmpty($queryLog);
         $this->assertTrue(isset($queryLog['test']));
         $this->assertEquals('query', $queryLog['test'][0]);
 
@@ -191,7 +191,7 @@ public function testNormalNestedExceptionRendering()
 
         $viewVars = $Controller->viewVars;
 
-        $this->assertTrue(!empty($viewVars['_serialize']));
+        $this->assertNotEmpty($viewVars['_serialize']);
 
         $expected = ['success', 'data'];
         $actual = $viewVars['_serialize'];
@@ -255,7 +255,7 @@ public function testMissingViewExceptionDuringRendering()
 
         $viewVars = $Controller->viewVars;
 
-        $this->assertTrue(!empty($viewVars['_serialize']));
+        $this->assertNotEmpty($viewVars['_serialize']);
 
         $expected = ['success', 'data'];
         $actual = $viewVars['_serialize'];
@@ -321,7 +321,7 @@ public function testGenericExceptionDuringRendering()
 
         $viewVars = $Controller->viewVars;
 
-        $this->assertTrue(!empty($viewVars['_serialize']));
+        $this->assertNotEmpty($viewVars['_serialize']);
 
         $expected = ['success', 'data'];
         $actual = $viewVars['_serialize'];