Allow multiple fields for value filter #135
Conversation
Current coverage is 100% (diff: 100%)@@ master #135 diff @@
====================================
Files 10 10
Lines 290 298 +8
Methods 51 52 +1
Messages 0 0
Branches 0 0
====================================
+ Hits 290 298 +8
Misses 0 0
Partials 0 0
|
|
|
||
| return $e; | ||
| }); | ||
| if (!empty($expressions)) { |
There was a problem hiding this comment.
It's a copy/paste from Like filter.
There was a problem hiding this comment.
Yeah ideally they both remove the not necessary cloaking. Bot no big deal.
|
Good idea 👍 |
| @@ -1,6 +1,9 @@ | |||
| <?php | |||
| namespace Search\Model\Filter; | |||
|
|
|||
| use Cake\Database\Expression\QueryExpression; | |||
| use Search\Manager; | |||
|
|
|||
| class Value extends Base | |||
There was a problem hiding this comment.
couldn't we make a MultiValue instead, this will otherwise be breaking change
There was a problem hiding this comment.
I would stay at Value otherwise we have an inconsistency between the usage of Like and Value. Where is the breaking change?
There was a problem hiding this comment.
The default config keys have changed named
|
What about merging? |
|
As said before I am 👍 on merging this |
|
Explicit multi field tests wouldn't hurt... |
|
Tests and readme update required. |
|
@steefaan Are you able to finish it up or do you want some help here? |
| { | ||
| parent::__construct($name, $manager, $config); | ||
|
|
||
| $mode = $this->config('mode'); |
There was a problem hiding this comment.
We could add an inline comment here:
// For backwards compatibility
etc
|
How can we finish this up? Anyone interested? |
|
I'll finish it up... |
I think it would be nice to provide the possibility to search a value inside multiple fields at once. This way the
Valuefilter acts asLikefilter. Code is BC, see the constructor.