Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emptyFields for PRG component in order for isSearch to stay correct #160

Merged
merged 1 commit into from Apr 25, 2017
Merged

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Apr 21, 2017

This came up a few times before as an issue if I recall correctly.

In my case

	echo $this->Form->input('search');
	echo $this->Form->input('has_missing_translation', ['type' => 'checkbox']);

The 0 posted will always result in the URL ?has_missing_translation=0, which then also affects the isSearch and the reset button in the process.
The empty values should be seen as such (as the CakeDC one did). This is a non-invasive minimal BC safe addition that resolves the issue.

@dereuromark
Copy link
Member Author

dereuromark commented Apr 25, 2017

Is this OK as minor prior to the major bump? It is fully BC.
Or include it in the other two PRs?

@ADmad ADmad merged commit 32d69ca into FriendsOfCake:master Apr 25, 2017
@dereuromark
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants