Split combined setters/getters for cleaner API. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
============================================
+ Coverage 99.68% 99.69% +<.01%
- Complexity 138 140 +2
============================================
Files 11 11
Lines 321 325 +4
============================================
+ Hits 320 324 +4
Misses 1 1
Continue to review full report at Codecov.
|
dereuromark
changed the title
added 2 commits
April 28, 2017 21:44
josegonzalez
approved these changes
Apr 29, 2017
| @@ -65,12 +65,12 @@ public function repository() | |||
| /** | |||
| * Return Table | |||
| * | |||
| * @return \Cake\ORM\Table Table Instance | |||
| * @return \Cake\Datasource\RepositoryInterface Repository Instance | |||
There was a problem hiding this comment.
This does change the return and it's not BC per-se, but I'm going to merge this in as it's the proper way to do things.
There was a problem hiding this comment.
It fixes only the doc block (semantic) to what the non-deprecated method already returns.
There was a problem hiding this comment.
Yep thats why I'm fine with merging as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #165
The different return types of useCollection() vs getCollection is especially important to clean up here.