Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve admin page #69

Merged
merged 1 commit into from Oct 28, 2022
Merged

Improve admin page #69

merged 1 commit into from Oct 28, 2022

Conversation

datlechin
Copy link
Contributor

@datlechin datlechin commented Sep 20, 2022 •
edited

This PR has changes:

  • Margin bottom from AdvancedPreferences to Save button
  • Fixed loading not showing when clicking enable feature buttons
  • Add disabled to Enable feature buttons

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot
Screenshot 2022-09-20 at 23 01 23

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@imorland imorland merged commit feaf53a into FriendsOfFlarum:master Oct 28, 2022
@datlechin datlechin deleted the improve_admin branch October 28, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@datlechin @imorland