Fix composer remaining open (minimised) when creating PD from user card #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So simple it's almost embarrasing, thank you for this @davwheat |
|
@imorland it still doesn't make sense to me though... Surely this should break in both instances of creating a PD? |
|
Checking this out now! 🕺 |
|
You're a 🌟 Thank you so much for this, I will merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
This is a super simple change which seems to fix the issue.
Moving the composer hide until after we've navigated to the new discussion makes the composer hide correctly.
Possibly some super weird and barely reproducible upstream bug?