Add timestamps to tag_user
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imorland
requested changes
Jun 7, 2022
There was a problem hiding this comment.
As flarum/framework#3435 - can we please modify so that the default value is not the timestamp of when the migration is run, please?
|
@imorland I am waiting for flarum/framework#3435 to be merged, then I will updated this PR here. |
imorland
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Database migration that add timestamps to the
tag_usertable.The timestamps are not really used anywhere in this extension, but can be very handy for analytics purposes.
This PR is kind of a follow-up of flarum/framework#3435
Reviewers should focus on:
The migration runs without error and doesn't cause any unwanted side-effects (including performance aspects).
Confirmed
composer test).