Specify wich table to select data from in join query #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Added a select(...) instruction to queries that join
users
andtag_user
.This shouldn't change anything for the extension as it is. But in my case, I have added columns to
tag_user
(using another extension) that would override columns of theusers
table when the join happens because the columns have the same name in both tables. Explicitly telling Laravel what table to select data from (users
) fixes that issue.Reviewers should focus on:
Nothing is broken. Notifications still go out normally to tag followers.
Confirmed
composer test
).Required changes: