Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify wich table to select data from in join query #55

Merged
merged 2 commits into from Oct 7, 2022
Merged

Specify wich table to select data from in join query #55

merged 2 commits into from Oct 7, 2022

Conversation

iPurpl3x
Copy link
Contributor

@iPurpl3x iPurpl3x commented Oct 7, 2022

Changes proposed in this pull request:
Added a select(...) instruction to queries that join users and tag_user.

This shouldn't change anything for the extension as it is. But in my case, I have added columns to tag_user (using another extension) that would override columns of the users table when the join happens because the columns have the same name in both tables. Explicitly telling Laravel what table to select data from (users) fixes that issue.

Reviewers should focus on:
Nothing is broken. Notifications still go out normally to tag followers.

Confirmed

  • Backend changes: tests are green (run composer test).

Required changes:

Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no issue

@clarkwinkelmann clarkwinkelmann merged commit 0d31436 into FriendsOfFlarum:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants