Many fixes & improvements #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Votes w/ value > 0 are upvotes, < 0 are downvotes. Right now only 1 & -1 are used, but this introduces the possibility of weighed votes & improves performance by allowing SQL to perform the SUM. Permissions have been moved to the posts instead of the discussion. A migration should keep current configurations working.
Last commit removed it on the frontend & simplified the backend to simply use existing bound Pusher and post & user IDs
|
How are you doing on this? Is it ready for review? |
|
I think it's ready for review, just a draft so its not merged yet. |
dsevillamartin
force-pushed
the
ds/improvements
branch
from
2986cee
to
e8f106f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to performance, resolving issues, better votes calculation for posts, discussions & users...
Pusher & votes modal are currently broken.Changed
typecolumn in DB to an integer to allow SUM through SQL directly.