Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rewrite to use relations for fields #68

Merged
merged 2 commits into from
Dec 23, 2021
Merged

fix: rewrite to use relations for fields #68

merged 2 commits into from
Dec 23, 2021

Conversation

davwheat
Copy link
Member

This is another breaking change, but only affects extensions which directly query the masquerade API endpoints.

Changes proposed in this pull request:

  • rewrites to use user relations for masquerade answers
    • fixes a bug where all users would show the same profile answers if you edited your own profile

Reviewers should focus on:

Honestly, everything.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tested on a local Flarum installation.

@davwheat davwheat added the bug label Dec 23, 2021
@davwheat davwheat self-assigned this Dec 23, 2021
@davwheat davwheat merged commit f2437af into master Dec 23, 2021
@davwheat davwheat deleted the dw/fix branch December 23, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees

@davwheat davwheat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davwheat @imorland