Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unset optional field #74

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

rafaucau
Copy link
Contributor

@rafaucau rafaucau commented Aug 1, 2022

Fixes #73

Changes proposed in this pull request:

This PR fixes the ability to unset an optional field.

Screenshot

2022-08-01.22-33-47.mp4

Confirmed

  • Frontend changes: tested on a local Flarum installation.

Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together, a very welcome change!

@imorland imorland merged commit 3fafff7 into FriendsOfFlarum:master Aug 1, 2022
@rafaucau rafaucau deleted the fix/optional_field branch August 1, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "No option selected" option does not work in an optional field
2 participants