Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: abstract excerpt method not implemented in notification component #39

Merged
merged 1 commit into from May 13, 2022
Merged

fix: abstract excerpt method not implemented in notification component #39

merged 1 commit into from May 13, 2022

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

Adds missing excerpt method implementation. This breaks the notification dropdown if not implemented.

Screenshot

image

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@davwheat davwheat requested a review from imorland May 13, 2022 20:51
@davwheat davwheat self-assigned this May 13, 2022
@imorland imorland merged commit 43df925 into master May 13, 2022
@imorland imorland deleted the dw/fix-notif-breaking branch May 13, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@imorland imorland imorland approved these changes

Assignees

@davwheat davwheat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davwheat @luceos @imorland