Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MEDIAEMBED_THEME rendering parameter #68

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clarkwinkelmann
Copy link
Member

This is more of a proof of concept because it's not really doing things the way we expect.

We should update the MEDIAEMBED_THEME rendering parameter based on the selected theme. Unfortunately I'm not sure we can change this value per-request in Flarum since the Formatter::configure extender only runs after a cache clear. There's also no way to access the actor or cookies from that extender so it would require additional code.

This PR is a working solution to always apply the default theme value as the MediaEmbed theme.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant