Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to icons flex layout #36

Merged
merged 3 commits into from Nov 6, 2021
Merged

Improvements to icons flex layout #36

merged 3 commits into from Nov 6, 2021

Conversation

dsevillamartin
Copy link
Member

  • Add container element for buttons
  • Add gap between buttons
  • Align google button in center

image

@imorland
Copy link
Member

imorland commented Nov 4, 2021 •
edited

Everything checks out for icons only, but the text is missing on the default layout:

image

Looks like it's a simple css issue:

image

imorland
imorland approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out fine locally

@dsevillamartin dsevillamartin merged commit 801d65a into master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsevillamartin @imorland