fix: phpstan errors

FriendsOfFlarum · Nov 12, 2023 · 11ef4ab · 11ef4ab
1 parent 707fbd9
commit 11ef4ab
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/src/Command/EditPageHandler.php b/src/Command/EditPageHandler.php
@@ -11,6 +11,7 @@
 
 namespace FoF\Pages\Command;
 
+use Carbon\Carbon;
 use FoF\Pages\PageRepository;
 use FoF\Pages\PageValidator;
 use Illuminate\Support\Arr;
@@ -79,7 +80,7 @@ public function handle(EditPage $command)
             $page->is_html = (bool) $attributes['isHtml'];
         }
 
-        $page->edit_time = time();
+        $page->edit_time = Carbon::now();
 
         $this->validator->assertValid($page->getDirty());
 

diff --git a/src/Page.php b/src/Page.php
@@ -18,14 +18,14 @@
 use Flarum\Post\Post;
 
 /**
- * @property string title
- * @property string slug
- * @property Carbon time
- * @property Carbon edit_time
- * @property string content
- * @property bool is_hidden
- * @property bool is_restricted
- * @property bool is_html
+ * @property string $title
+ * @property string $slug
+ * @property Carbon $time
+ * @property Carbon $edit_time
+ * @property string $content
+ * @property bool $is_hidden
+ * @property bool $is_restricted
+ * @property bool $is_html
  */
 class Page extends AbstractModel
 {
@@ -69,7 +69,7 @@ public static function build($title, $slug, $content, $isHidden, $isRestricted,
 
         $page->title = $title;
         $page->slug = $slug;
-        $page->time = time();
+        $page->time = Carbon::now();
         $page->content = $content;
         $page->is_restricted = (bool) $isRestricted;
         $page->is_hidden = (bool) $isHidden;

diff --git a/src/PageRepository.php b/src/PageRepository.php
@@ -39,7 +39,7 @@ public function query()
      */
     public function findOrFail($id, User $user = null)
     {
-        return $this->query()
+        return Page::query()
             // We never pass a null $user from our own code, but third-party extensions
             // like v17development/flarum-seo do it so we must allow null for backward compatibility
             ->whereVisibleTo($user ?? new Guest())

diff --git a/src/Search/NoOpGambit.php b/src/Search/NoOpGambit.php
@@ -35,5 +35,6 @@ public function filter(FilterState $filterState, string $filterValue, bool $nega
     public function apply(SearchState $search, $bit)
     {
         // Does nothing
+        return false;
     }
 }