Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI improvements #71

Merged
merged 7 commits into from Jun 21, 2023
Merged

UI improvements #71

merged 7 commits into from Jun 21, 2023

Conversation

dsevillamartin
Copy link
Member

@dsevillamartin dsevillamartin commented Jun 18, 2023 •
edited

Fixes #8

Changes proposed in this pull request:

  • Convert float to grid for options list and flex for the options themselves
  • Fix duplicate timing message when the poll timer has ended
  • Load votes for votes modal after opening, instead of before
  • Improve layout margin & image positioning
  • Use grid for voters list in modal

Reviewers should focus on:

Screenshot

Details

Screenshot 2023-06-18 183521
Screenshot 2023-06-18 183551

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@dsevillamartin dsevillamartin changed the title Ds/UI improvements UI improvements Jun 18, 2023
@dsevillamartin
Copy link
Member Author

image

@dsevillamartin
Copy link
Member Author

image

@dsevillamartin dsevillamartin merged commit 47aa721 into master Jun 21, 2023
3 checks passed
@dsevillamartin dsevillamartin deleted the ds/ui-improvements branch July 6, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poll options look very untidy on mobile mode / small resolutions
1 participant
@dsevillamartin