Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop flatpickr #72

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Drop flatpickr #72

merged 3 commits into from
Jul 6, 2023

Conversation

dsevillamartin
Copy link
Member

@dsevillamartin dsevillamartin commented Jun 21, 2023 •
edited

Fixes #27

Changes proposed in this pull request:

  • Replace flatpickr with datetime-local
  • Add more obvious error-validating effect to inputs
  • Modify some PHP code to make sure datetimes are saved in UTC
    • Carbon::createFromTimeString seemed to be removing the timestamp part of the formatted time string and not being saved in UTC to DB

Reviewers should focus on:
datetime-local support has been fully supported by major browsers for around ~1.5 years. When the last PR was made for this (#48), support seemed to be very early in both Safari & Firefox.

BrowserStack iOS on MDN

image

Screenshot
image
image
image

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@dsevillamartin dsevillamartin changed the base branch from master to v2 July 6, 2023 14:11
@dsevillamartin dsevillamartin merged commit 9e99d23 into v2 Jul 6, 2023
3 checks passed
This was referenced Jul 10, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poll end date panel broken
3 participants
@dsevillamartin @imorland @StyleCIBot