Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Storage #140

Closed
genxstylez opened this issue May 30, 2018 · 4 comments
Closed

Google Cloud Storage #140

genxstylez opened this issue May 30, 2018 · 4 comments
Labels

Comments

@genxstylez
Copy link

Hi, Is there any plans for integrating Google Cloud Storage?

Or can anyone point me how to do it?

@luceos luceos added the adapter label May 30, 2018
@luceos
Copy link
Contributor

luceos commented May 30, 2018

Can you point me to the documentation? If you're up for it you can try to write your own adapter.

@genxstylez
Copy link
Author

https://github.com/Superbalist/flysystem-google-cloud-storage

@jadsonlourenco
Copy link

Well, I did something that worked to me for now, but I not will submit as PR because I don't know PHP.

https://github.com/jadsonlourenco/upload/tree/google-cloud-storage

Just config with:
1. Project ID [String] (Your Google Cloud project ID)
2. Credentials file [String] (ex: /path-to-secrect.json)
3. Bucker name [String]

@luceos
Copy link
Contributor

luceos commented Jun 11, 2021

Hi there and thank you for suggesting this upload adapter for fof/upload.

In order to keep this extension maintainable with the few number of people currently involved with it, we do not accept pull requests or feature requests for new upload adapters. The reason for this is that we would need to test the adapter on each upgrade of Flarum, plus whenever changes occur on this API of the upload service.

As a small team maintaining many extensions isn't always easy. That's why we try to reduce the workload by making clear choices on what we do and don't support .

The best option you have is to (have someone) create a completely new extension that registers the additional upload adapter. The maintenance of that extension is then dispersed away from our team. The best way to add your adapter is by listening to the Collecting event using the Flarum\Extend\Event extender.

If you have any questions about the implementation, feel free to open a discussion on the dev tag on discuss.

Thank you for your understanding.

@luceos luceos closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants