Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor services injection #38

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Jan 27, 2024

This PR simplifies the bundle extension by heavily relying on Symfony dependency injection through service configuration.

Closes #29.

@gaelreyrol gaelreyrol self-assigned this Jan 27, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 383 lines in your changes are missing coverage. Please review.

Comparison is base (ad4a4f3) 64.09% compared to head (eb490cf) 35.28%.

Files Patch % Lines
src/Resources/config/services_metrics.php 0.00% 65 Missing ⚠️
src/Resources/config/services_traces.php 0.00% 62 Missing ⚠️
src/Resources/config/services_logs.php 0.00% 61 Missing ⚠️
...pendencyInjection/OpenTelemetryTracesExtension.php 0.00% 30 Missing ⚠️
src/Resources/config/services_transports.php 0.00% 28 Missing ⚠️
...DependencyInjection/OpenTelemetryLogsExtension.php 0.00% 25 Missing ⚠️
...endencyInjection/OpenTelemetryMetricsExtension.php 0.00% 20 Missing ⚠️
src/Resources/config/services.php 0.00% 17 Missing ⚠️
src/OpenTelemetry/Metric/ExemplarFilterFactory.php 0.00% 8 Missing ⚠️
src/DependencyInjection/OpenTelemetryExtension.php 0.00% 7 Missing ⚠️
... and 30 more
Additional details and impacted files
@@              Coverage Diff              @@
##               main      #38       +/-   ##
=============================================
- Coverage     64.09%   35.28%   -28.82%     
+ Complexity      539      531        -8     
=============================================
  Files            98      112       +14     
  Lines          2337     2378       +41     
=============================================
- Hits           1498      839      -659     
- Misses          839     1539      +700     
Flag Coverage Δ
phpunit 35.28% <25.48%> (-28.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaelreyrol gaelreyrol marked this pull request as ready for review February 2, 2024 07:58
@gaelreyrol gaelreyrol requested a review from a team as a code owner February 2, 2024 07:58
@gaelreyrol gaelreyrol added this to the Alpha milestone Feb 2, 2024
@gaelreyrol gaelreyrol merged commit 613f1a3 into main Feb 2, 2024
11 of 15 checks passed
@gaelreyrol gaelreyrol deleted the refacto/service-factories branch February 2, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use service identifiers instead of raw keys in configuration
1 participant