Fixer for changing array_push($a, $b) to $a[] = $b #3483

ntzm · 2018-01-29T13:49:53Z

Note: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function.

Source: https://secure.php.net/manual/en/function.array-push.php

I think this fixer may be risky because there is a change in behaviour:

Note: array_push() will raise a warning if the first argument is not an array. This differs from the $var[] behaviour where a new array is created.

This PR was merged into the 2.17-dev branch. Discussion ---------- ArrayPushFixer - introduction ``` possum@aquarium:/home/possum/work/PHP-CS-Fixer$ php php-cs-fixer describe array_push Description of array_push rule. Converts simple usages of ``array_push($x, $y);`` to ``$x[] = $y;``. Fixer applying this rule is risky. Risky when the function `array_push` is overridden. Fixing examples: * Example #1. ``` ```diff --- Original +++ New @@ -1,2 +1,2 @@ <?php -array_push($x, $y); +$x[] = $y; ``` closes #3483 Commits ------- 4400ea5 ArrayPushFixer - introduction

SpacePossum · 2020-04-11T10:37:12Z

added in #4790

SpacePossum added the kind/feature request label Feb 6, 2018

SpacePossum mentioned this issue Feb 10, 2020

ArrayPushFixer - introduction #4790

Merged

SpacePossum closed this as completed Apr 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixer for changing array_push($a, $b) to $a[] = $b #3483

Fixer for changing array_push($a, $b) to $a[] = $b #3483

ntzm commented Jan 29, 2018 •

edited

SpacePossum commented Apr 11, 2020

Fixer for changing array_push($a, $b) to $a[] = $b #3483

Fixer for changing array_push($a, $b) to $a[] = $b #3483

Comments

ntzm commented Jan 29, 2018 • edited

SpacePossum commented Apr 11, 2020

ntzm commented Jan 29, 2018 •

edited