Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: new rule - no_unneeded_unpacking #4540

Closed
keradus opened this issue Sep 1, 2019 · 3 comments
Closed

Feature request: new rule - no_unneeded_unpacking #4540

keradus opened this issue Sep 1, 2019 · 3 comments
Labels

Comments

@keradus
Copy link
Member

keradus commented Sep 1, 2019

-myFunction(...[1, 2, 3]);
+myFunction(1, 2, 3);

but no changes here:

 $args = generateArgs();
 myFunction(...generateArgs());
 myFunction(...$args);

rule should run after rule introduced in #4460

@Wirone Wirone added status/to verify issue needs to be confirmed or analysed to continue contribution welcome Core team is looking for a contribution and removed status/to verify issue needs to be confirmed or analysed to continue labels May 16, 2023
@github-actions

This comment was marked as outdated.

@Wirone Wirone changed the title Feature request: new rule - no_unneeded_unpacking Feature request: new rule - no_unneeded_unpacking Aug 19, 2023

This comment was marked as outdated.

Copy link

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way.

You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point.

I will close it if no further activity occurs within the next 30 days.

@PHP-CS-Fixer PHP-CS-Fixer locked and limited conversation to collaborators Feb 22, 2024
@Wirone Wirone converted this issue into discussion #7850 Feb 22, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

2 participants