Add PSR12 ruleset

[julienfalque]

Ref: #4502.

[drupol]

Can't wait for this :)

[drupol]

Just FYI,

On my side, I'm using a package of mine implementing this ruleset among some others.

This is completely in sync with PHPCS and ECS.

The configuration for PSR12 is here, maybe that will help.

The scripts i'm using in composer.json:

  "scripts": {
    "phpcsfixer": "vendor/bin/php-cs-fixer  --dry-run --allow-risky=yes --config=./vendor/drupol/php-conventions/config/psr12/php_cs_fixer.config.php --using-cache=no --verbose fix",
  }

[julienfalque]

Thanks @drupol, I updated the ruleset :)

[drupol]

Great, glad it helped :)

[drupol]

Weird issue.

There was 1 failure:

1) PhpCsFixer\Tests\RuleSetTest::testDuplicateRuleConfigurationInSetDefinitions

"@PSR12" defines rules the same as it extends from:
- "visibility_required" is also in "@PSR2"

"@Symfony" defines rules the same as it extends from:
- "visibility_required" is also in "@PSR12"

/home/travis/build/FriendsOfPHP/PHP-CS-Fixer/tests/RuleSetTest.php:639

Overriding rules is not allowed ?!

[julienfalque]

Our tests prevent having a ruleset that overrides a rule with the exact same config.

[julienfalque]

@nicolas-grekas @fabpot This introduces changes in the @Symfony ruleset, are you ok with those?

[nicolas-grekas]

I ran this PR on the Symfony, there are some suspicious changes, but looks good otherwise.

Here are the changes that I think should not happen:

[drupol]

Hi,

Just for the record, here are the rules (and the ruleset that uses them) from your screenshots.

ordered_imports [@Symfony, @PhpCsFixer]

full_opening_tag [@PSR1, @PSR2, @Symfony, @PhpCsFixer]

global_namespace_import

[julienfalque]

@nicolas-grekas Having trait imports at the very beginning of classes is required by PSR-12, do you mean you don't want Symfony's coding style to follow that specific rule?

The second change looks like a bug unrelated to this PR, <?= is supposed to be allowed. In which file was that change introduced?

The last change looks unrelated to this PR, global_namespace_import isn't part of any ruleset.

[fabpot]

Having trait imports at the beginning of the classes looks ok to me.

[kubawerlos]

@nicolas-grekas @julienfalque last change is related to "strict" flag for NativeConstantInvocationFixer which will be released in 2.17.

[nicolas-grekas]

last change is related to "strict" flag for NativeConstantInvocationFixer which will be released in 2.17.

OK, then that's something that NativeConstantInvocationFixer should not do for some selected constants. PHP_INT_SIZE is one of them: while for most other constants we don't care, this one, but also e.g. PHP_VERSION_ID, is used by PHP at compile time to optimize the compiled opcodes. Removing the \ breaks the optimization.

I think looking at which constants have a leading \ in the codebase could give the list. PHP_DIRECTORY_SEPARATOR is one of them.

[kubawerlos]

Like these https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v2.16.3/src/RuleSet.php#L193?

The only update in 2.17 would be making it strict.

[nicolas-grekas]

Yes, this. PHP_INT_SIZE should be added to the list.