Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeAlternationTransformer - add support for PHP8 #5405

Merged
merged 1 commit into from Dec 31, 2020
Merged

TypeAlternationTransformer - add support for PHP8 #5405

merged 1 commit into from Dec 31, 2020

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Dec 30, 2020 •
edited

part of #5399 and PHP8 support

@SpacePossum SpacePossum added topic/PHP8.0 Related to features available in PHP 8.0+ kind/enhancement labels Dec 30, 2020
@SpacePossum SpacePossum added this to the 2.17.4 milestone Dec 30, 2020
@SpacePossum SpacePossum mentioned this pull request Dec 30, 2020
Merged
6 tasks
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 91.36% when pulling 559b1a6 on SpacePossum:2_17_PHP8_TypeAlternationTransformer into 98dd819 on FriendsOfPHP:2.17.

@SpacePossum SpacePossum merged commit 1a4510e into PHP-CS-Fixer:2.17 Dec 31, 2020
@SpacePossum SpacePossum deleted the 2_17_PHP8_TypeAlternationTransformer branch December 31, 2020 14:11
keradus added a commit that referenced this pull request Jan 18, 2021
@keradus
minor #5399 Add PHP8 integration test (keradus)
f209e6d 
This PR was squashed before being merged into the 2.17 branch.

Discussion
----------

Add PHP8 integration test

ref #4702

There are ~3~ 4 cases still crashing in the spec files:
- [x] nullsafe operator -> PHP 8.0.1 to be released at 7th
- [x] attributes #5406
- [x] union types for method parameters #5405
- [x] union types for class properties #5439

I also found the following issues that I raised as separated PRs:
- [x] ~#5396~ -> #5397
- [x] ~#5400~ -> #5404

Commits
-------

324929f Add PHP8 integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/enhancement topic/PHP8.0 Related to features available in PHP 8.0+
Projects
None yet
Milestone
2.17.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SpacePossum @coveralls