Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoExtraBlankLinesFixer - add failing test case #5396

Closed
wants to merge 1 commit into from
Closed

NoExtraBlankLinesFixer - add failing test case #5396

wants to merge 1 commit into from

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 28, 2020

follow up after #5232 ,
can you take a look, @SpacePossum ?

@SpacePossum SpacePossum mentioned this pull request Dec 28, 2020
Merged
@keradus keradus mentioned this pull request Dec 28, 2020
Merged
6 tasks
@keradus
Copy link
Member Author

keradus commented Dec 28, 2020

replaced by #5397, thanks @SpacePossum !

@keradus keradus closed this Dec 28, 2020
@keradus keradus deleted the 2.17_5232 branch December 28, 2020 17:28
SpacePossum added a commit that referenced this pull request Dec 31, 2020
@SpacePossum
minor #5397 NoExtraBlankLinesFixer - PHP8 throw support (SpacePossum)
fb0b660 
This PR was merged into the 2.17 branch.

Discussion
----------

NoExtraBlankLinesFixer - PHP8 throw support

replaces #5396
cc @keradus

Commits
-------

f6c6bff NoExtraBlankLinesFixer - PHP8 throw support
keradus added a commit that referenced this pull request Jan 18, 2021
@keradus
minor #5399 Add PHP8 integration test (keradus)
f209e6d 
This PR was squashed before being merged into the 2.17 branch.

Discussion
----------

Add PHP8 integration test

ref #4702

There are ~3~ 4 cases still crashing in the spec files:
- [x] nullsafe operator -> PHP 8.0.1 to be released at 7th
- [x] attributes #5406
- [x] union types for method parameters #5405
- [x] union types for class properties #5439

I also found the following issues that I raised as separated PRs:
- [x] ~#5396~ -> #5397
- [x] ~#5400~ -> #5404

Commits
-------

324929f Add PHP8 integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@keradus