NoAliasFunctionsFixer - Add more function aliases

[danog]

Extracted directly from the PHP trunk (master&7.4).

[coveralls]

Coverage decreased (-0.004%) to 92.172% when pulling ae5a964 on zoonru:2.18 into 2963845 on FriendsOfPHP:master.

[danog]

Note quite sure what to make of the phpstan analysis, seems like a bug to me (mixed is a supertype of string; plus the error is not triggered on other lines of the elseif))
As a friendly recommendation from a psalm lover, I can really recommend switching to https://psalm.dev for static analysis :)

[kubawerlos]

That's weird, I've reported a bug: phpstan/phpstan#4793 - check out the example, it's really strange.

As workaround you can add above the line with foreach ($this->configuration['sets'] as $set) { PHPdoc like this: /** @var string $set */

I can really recommend switching to https://psalm.dev

Why not both? I often use both as the can detect different issues and both have some bugs.

[GrahamCampbell]

Needs tests covering some of these options.

[SpacePossum]

Thanks @danog for these improvements :)

Please add the some tests here and have a look at my minors, looking close to finished

[danog]

Finally got around to finishing this MR :)
Applied the requested changes, and added some tests based on the existing test logic.
The only detail that I'm not sure about is the @pg set: the only alias function contained in that set is the extremely old pg_exec alias, deprecated way back in PHP 4.
I'm not sure if it's worth removing from the defaults.

[danog]

All OK over here? :)

[keradus]

@danog can you rebase on 2.19 or allow to modify your branch by us? we need to ensure that CI kicks off for this PR and all jobs to be green, before we are able to merge.

[keradus]

I don't see it solving any bug in the existing fixer. it's giving existing fixer more functionality (to handle more aliases)

should go to 3.1 line

[danog]

There, all fixed up nicely.

[keradus]

Thank you @danog.