Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for strict rules with nested ifelse #4793

Closed
kubawerlos opened this issue Apr 2, 2021 · 4 comments
Closed

False positive for strict rules with nested ifelse #4793

kubawerlos opened this issue Apr 2, 2021 · 4 comments
Labels
bug

Comments

@kubawerlos
Copy link
Contributor

Bug report

When there is too many elseif in some there are some false positives.

Code snippet that reproduces the problem

https://phpstan.org/r/e5986c54-a145-41e2-9f31-8e7e3fc730cb

Expected output

No error
@ondrejmirtes
Copy link
Member

Linking with #3555

@kubawerlos kubawerlos mentioned this issue Apr 2, 2021
Closed
@kubawerlos
Copy link
Contributor Author

OMG, what a name for the other issue, I only briefly looked if this is already reported, @ondrejmirtes feel free to close this as duplicate.

@ondrejmirtes
Copy link
Member

I managed to solve this.

Look forward to the next release (0.12.95) :)

ondrejmirtes added a commit to phpstan/phpstan-src that referenced this issue Aug 31, 2021
@ondrejmirtes
Regression tests
3c41113 
Ref phpstan/phpstan#4793
Ref phpstan/phpstan#5062
Ref phpstan/phpstan#5447
Ref phpstan/phpstan#5454
Ref phpstan/phpstan#3366
Ref phpstan/phpstan#5072
Ref phpstan/phpstan#3530
Ref phpstan/phpstan#5530
Ref phpstan/phpstan#1861
Ref phpstan/phpstan#4843
Ref phpstan/phpstan#4602
Ref phpstan/phpstan#4499
Ref phpstan/phpstan#2142
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrejmirtes @kubawerlos