Remove |null from union types when null is the default

[nicolas-grekas]

I don't remember: do we have a rule to turn an argument like ?foo $bar = null into foo $bat = null, don't we?
We might need one if not :)

And with union types, this rule should also turn foo|bar|null $bar = null into foo|bar $bar = null.

🙏

[keradus]

can you share the reasoning behind such rule, @nicolas-grekas ?
frankly speaking, I would rather to the opposite, if argument is optional, I would add ?/null to the typehint, if missing

[nicolas-grekas]

With union types, signatures are already very long. That CS style makes them a bit shorter without any downside.
Also, that's two possible styles. A CS fixer tool is supposed to normalize, and there are two ways here.

[julienfalque]

do we have a rule to turn an argument like ?foo $bar = null into foo = null

Did you mean

-?foo $bar = null
+foo $bar = null

?

[nicolas-grekas]

@julienfalque yes, updated

[kubawerlos]

@nicolas-grekas like this: nullable_type_declaration_for_default_null_value?

[julienfalque]

Ah yes, I forgot this rule has an option to make the reverse change. Closing then, thanks @kubawerlos :)

[julienfalque]

Mmmh actually the rule does not cover the |null part in union types. Maybe we could simply update it.

[Wirone]

@nicolas-grekas it took 2 years, but finally it's done 😁. Thank you @HypeMC for this great improvement.