Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: SymfonySet - Add nullable_type_declaration_for_default_null_value #6390

Closed
wants to merge 1 commit into from

Conversation

SpacePossum
Copy link
Contributor

Following preference expressed here #5785 by two maintainers of the projects.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.873% when pulling a95984a on SpacePossum:master_5785 into f736dc9 on FriendsOfPHP:master.

@SpacePossum SpacePossum changed the title SymfonySet - Add nullable_type_declaration_for_default_null_value minor: SymfonySet - Add nullable_type_declaration_for_default_null_value Jun 13, 2022
@keradus
Copy link
Member

keradus commented Jul 10, 2022

not sure if I got you on this one, @SpacePossum
To my understanding, the wish of Sf maintainers was to remove ? in such cases, and your PR configure the opposite?

(myself, I would rather enforce having ?, and if declaration gets too long, that could suggest other change in first place)

@SpacePossum
Copy link
Contributor Author

Indeed, thanks, closing as invalid 👍

@SpacePossum SpacePossum deleted the master_5785 branch July 18, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants