ProtectedToPrivateFixer - Use backticks for visibility in description #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, using single backticks has no effect for RST rendering, should we be using double backticks to have those rendered as code?
|
|
Single ones will be rendered as |
|
i think we could handle this on readme generator |
keradus
changed the title
|
Thank you @localheinz. |
keradus
added a commit
that referenced
this pull request
Dec 17, 2016
… description (localheinz) This PR was merged into the 2.0-dev branch. Discussion ---------- ProtectedToPrivateFixer - Use backticks for visibility in description This PR * [ ] encloses `protected` and `private` in backticks in the description of the `ProtectedToPrivateFixer` Follows #2400. Commits ------- e8e15c6 Fix: Use backticks for visibility in description
|
@SpacePossum could you take a look at rst rendering issue ? |
|
Thank you, @keradus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
protectedandprivatein backticks in the description of theProtectedToPrivateFixerFollows #2400.