Add Fixer descriptions #2400
Closed
Add Fixer descriptions #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
localheinz
reviewed
Dec 15, 2016
| | Replaces rand, srand, getrandmax functions calls with their mt_* | ||
| | analogs. | ||
| | Replaces `rand`, `mt_rand`, `srand`, `getrandmax` functions calls with | ||
| | their mt_* analogs. |
There was a problem hiding this comment.
Should mt_* also be embedded within back ticks?
| new CodeSample('<?php echo(\'example\');', array('use' => 'print')), | ||
| ), | ||
| null, | ||
| 'The fixer can be configured to change `print` to `echo` `[\'use\' => \'echo\']` or `echo` to `print` `[\'use\' => \'print\']`.', |
There was a problem hiding this comment.
How about using double quotes here so we don't need to escape single quotes?
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function isCandidate(Tokens $tokens) |
There was a problem hiding this comment.
Wondering, should the reordering be done by a fixer? 😄
There was a problem hiding this comment.
ordered_class_elements ? ;)
|
Thank you @SpacePossum. |
|
Great work here! |
1 task
keradus
added a commit
that referenced
this pull request
Dec 17, 2016
… description (localheinz) This PR was merged into the 2.0-dev branch. Discussion ---------- ProtectedToPrivateFixer - Use backticks for visibility in description This PR * [ ] encloses `protected` and `private` in backticks in the description of the `ProtectedToPrivateFixer` Follows #2400. Commits ------- e8e15c6 Fix: Use backticks for visibility in description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.