HeaderCommentFixer - throw exception on invalid header configuration #4099

SpacePossum · 2018-11-13T09:33:22Z

kubawerlos · 2018-11-13T09:44:45Z

What about comment type? It also cannot have */.

SpacePossum · 2018-11-13T10:05:12Z

thanks @kubawerlos , updated 👍

kubawerlos · 2018-11-13T10:13:13Z

src/Fixer/Comment/HeaderCommentFixer.php

                    if ('' === trim($value)) {
                        return '';
                    }

+                    if (false !== strpos($value, '*/')) {
+                        throw new InvalidFixerConfigurationException($fixerName, 'Cannot use \'*/\' in header.');


Can't $this->getName() be instead of $fixerName here?

I first thought the same, however, this is a static closure, thus not bound to $this. See http://php.net/manual/en/functions.anonymous.php#functions.anonymous-functions.static

Do we need this closure to be static?

even after dropping the static here won't bring the HeaderCommentFixer into the $this context

(Error: Using $this when not in object context)

we are in;
fixer > new FixerConfigurationResolver > new FixerOptionBuilder > closure

…iguration (SpacePossum) This PR was squashed before being merged into the 2.12 branch (closes #4099). Discussion ---------- HeaderCommentFixer - throw exception on invalid header configuration closes #4075 Commits ------- 273fa48 HeaderCommentFixer - throw exception on invalid header configuration

SpacePossum added the kind/bug label Nov 13, 2018

SpacePossum added this to the 2.12.5 milestone Nov 13, 2018

kubawerlos reviewed Nov 13, 2018

View reviewed changes

dmvdbrugge approved these changes Nov 13, 2018

View reviewed changes

kubawerlos approved these changes Nov 13, 2018

View reviewed changes

HeaderCommentFixer - throw exception on invalid header configuration

273fa48

SpacePossum merged commit 273fa48 into PHP-CS-Fixer:2.12 Nov 27, 2018

keradus deleted the 2_12_throw_config_error_on_invalid_header branch November 28, 2018 00:46

SpacePossum mentioned this pull request Dec 12, 2018

HeaderCommentFixer - throw exception on invalid header configuration (II) #4147

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HeaderCommentFixer - throw exception on invalid header configuration #4099

HeaderCommentFixer - throw exception on invalid header configuration #4099

SpacePossum commented Nov 13, 2018

kubawerlos commented Nov 13, 2018

SpacePossum commented Nov 13, 2018

kubawerlos Nov 13, 2018

dmvdbrugge Nov 13, 2018

kubawerlos Nov 13, 2018

SpacePossum Nov 13, 2018 •

edited

Loading

HeaderCommentFixer - throw exception on invalid header configuration #4099

HeaderCommentFixer - throw exception on invalid header configuration #4099

Conversation

SpacePossum commented Nov 13, 2018

kubawerlos commented Nov 13, 2018

SpacePossum commented Nov 13, 2018

kubawerlos Nov 13, 2018

Choose a reason for hiding this comment

dmvdbrugge Nov 13, 2018

Choose a reason for hiding this comment

kubawerlos Nov 13, 2018

Choose a reason for hiding this comment

SpacePossum Nov 13, 2018 • edited Loading

Choose a reason for hiding this comment

SpacePossum Nov 13, 2018 •

edited

Loading