DX: Tokens - do not unregister/register found tokens when collection is not changing #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
added
the
status/to verify
keradus
removed
the
status/to verify
keradus
approved these changes
Feb 10, 2019
|
Thank you @kubawerlos. |
keradus
added a commit
that referenced
this pull request
Feb 10, 2019
… collection is not changing (kubawerlos) This PR was merged into the 2.12 branch. Discussion ---------- DX: Tokens - do not unregister/register found tokens when collection is not changing This makes sence, right? Only run `unregisterFoundToken`/`registerFoundToken` when changing collection. Commits ------- 12edc3d DX: Tokens - do not unregister/register found tokens when it is the same token
kubawerlos
deleted the
dx-modify-registered-tokens-only-when-changing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sence, right?
Only run
unregisterFoundToken/registerFoundTokenwhen changing collection.