DX: more specific @param types #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
reviewed
Jan 4, 2019
| @@ -64,7 +64,7 @@ public function getClassyElements() | |||
| * | |||
| * @param bool $perNamespace Return namespace uses per namespace | |||
| * | |||
| * @return array|array[] | |||
| * @return int[]|int[][] | |||
There was a problem hiding this comment.
the int[] is really an empty array here I think, than again int[] might be a better fit
SpacePossum
approved these changes
Jan 4, 2019
|
Thank you @kubawerlos. |
keradus
added a commit
that referenced
this pull request
Feb 3, 2019
This PR was merged into the 2.12 branch. Discussion ---------- DX: more specific @param types A source was this part of the PHPStan report: ``` ------ ------------------------------------------------------------------ Line Fixer/Import/SingleLineAfterImportsFixer.php ------ ------------------------------------------------------------------ 86 Binary operation "+=" between array and int results in an error. ------ ------------------------------------------------------------------ ------ ---------------------------------------------------------------- Line Fixer/LanguageConstruct/NoUnsetOnPropertyFixer.php ------ ---------------------------------------------------------------- 204 Binary operation "+" between string and 1 results in an error. 222 Binary operation "+" between string and 1 results in an error. ------ ---------------------------------------------------------------- ``` Commits ------- a583a14 DX: more specific @param types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A source was this part of the PHPStan report: