DX: handle deprecations of symfony/event-dispatcher:4.3 #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
reviewed
May 31, 2019
| @@ -105,6 +105,15 @@ private function dispatchEvent($name, Event $event) | |||
| return; | |||
| } | |||
|
|
|||
| $this->eventDispatcher->dispatch($name, $event); | |||
| // BC compatibility < Sf 4.3 | |||
| if ( | |||
There was a problem hiding this comment.
Could we have the condition like this one?
There was a problem hiding this comment.
not really, you can have PsrEventDispatcherInterface installed anyway while having Sf component v3
you want to check instance you are using, not aside library that may or may not be installed
There was a problem hiding this comment.
also, you may have sf component v4.3 with deprecation warning and not have psr/event-dispatcher installed
kubawerlos
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.