NotOperatorWithSpaceFixer - NotOperatorWithSuccessorSpaceFixer - depr… #4735
Conversation
| @@ -1851,6 +1852,12 @@ Choose from the list of available rules: | |||
|
|
|||
| Unary operators should be placed adjacent to their operands. | |||
|
|
|||
| Configuration options: | |||
|
|
|||
| - ``not_operator_space`` (``'leading_and_trailing'``, ``'no_trailing'``, | |||
There was a problem hiding this comment.
This got me confused as the new user of PHP CS Fixer - why only those 3 options? Where are no_leading_and_trailing, no_leading and one_leading options? Are they "worse" then added 3?
Wouldn't be more clear to have 2 boolean options leading and trailing with value true|false|null to cover all combination?
There was a problem hiding this comment.
I moved the current logic of the fixers into one and made the difference in behavior available through these configuration options. I didn't spend time on investigating new or better options, so thanks for the suggestion!
There was a problem hiding this comment.
Ok, and no_trailing is the default for new fixer, I missed that, now I get it 👍
| @@ -48,7 +50,15 @@ public function getDefinition() | |||
| */ | |||
| public function getPriority() | |||
There was a problem hiding this comment.
This method can be dropped now.
| @@ -48,7 +50,15 @@ public function getDefinition() | |||
| */ | |||
| public function getPriority() | |||
There was a problem hiding this comment.
This method can be dropped now.
| { | ||
| return new FixerConfigurationResolver( | ||
| [ | ||
| (new FixerOptionBuilder('not_operator_space', 'Space around logical `!` (`not`) operators.')) |
There was a problem hiding this comment.
Wouldn't it be better to have an operators option supporting all possible operators like binary_operator_spaces has?
|
@SpacePossum deprecations cannot be added to a patch version, this must be merged into master. |
|
Im pushing this back to the discussion about the request so we can agree on what to do there, thanks all for the reviewing! |
closes
#4674