Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotOperatorWithSpaceFixer - NotOperatorWithSuccessorSpaceFixer - depr… #4735

Open
wants to merge 1 commit into
base: 2.15
from

Conversation

@SpacePossum
Copy link
Member

SpacePossum commented Jan 13, 2020

closes

#4674

@SpacePossum SpacePossum force-pushed the SpacePossum:2_15_4674_merge_not_op branch from 896c129 to 163133d Jan 13, 2020
@SpacePossum SpacePossum added this to the 2.15.6 milestone Jan 22, 2020
@@ -1851,6 +1852,12 @@ Choose from the list of available rules:

Unary operators should be placed adjacent to their operands.

Configuration options:

- ``not_operator_space`` (``'leading_and_trailing'``, ``'no_trailing'``,

This comment has been minimized.

Copy link
@kubawerlos

kubawerlos Jan 23, 2020

Contributor

This got me confused as the new user of PHP CS Fixer - why only those 3 options? Where are no_leading_and_trailing, no_leading and one_leading options? Are they "worse" then added 3?

Wouldn't be more clear to have 2 boolean options leading and trailing with value true|false|null to cover all combination?

This comment has been minimized.

Copy link
@SpacePossum

SpacePossum Jan 23, 2020

Author Member

I moved the current logic of the fixers into one and made the difference in behavior available through these configuration options. I didn't spend time on investigating new or better options, so thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.