-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed php-cs-fixer crashes on input file syntax error #5068
Conversation
ec7c280
to
1e86025
Compare
4ad1f9b
to
a3cc021
Compare
0c89140
to
93a42c0
Compare
Friendly ping @SpacePossum. |
93a42c0
to
474d730
Compare
- Fixed invalid syntax of test cases
474d730
to
3502c8a
Compare
Thank you @GrahamCampbell ! Great to see this fixed, lots of nice fixes, much appreciated 👍 Sorry for the wait, finally got a way to test on multiple PHP versions locally. FYI I've rebased and squashed your branch. |
Did you remove the extra spaces in the error message? I added them to match the format from the native linter, which has two spaces after the colon. |
I did indeed, however all tests did pass on the CI and local, you think this is going to be an issue somewhere? |
I just left it in for consistency. Maybe we could remove the double spaces from the native linter? |
Sounds good, we don't have a BC promise on exception messages anyway. Can you PR it or maybe link the related code than I can do it later on? |
Oh, you changed the message prefix too? I specifically had it so it matched the native linter output. |
#5174 should address the issues, ensuring consistent error messages. |
Closes #5067.