Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend priority test for "class_definition" vs "braces" #5577

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Extend priority test for "class_definition" vs "braces" #5577

merged 1 commit into from
Apr 3, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Mar 25, 2021

closes #5566

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.849% when pulling 66e8a0f on kubawerlos:extend_priority_test_for_class_definition_vs_braces into 61b9090 on FriendsOfPHP:2.18.

@keradus
Copy link
Member

keradus commented Apr 2, 2021

@kubawerlos , should we close #5566 with merge of this PR?

@kubawerlos
Copy link
Contributor Author

kubawerlos commented Apr 2, 2021

@keradus well, the simple answer is no, as this is only extending test to make it more explicit, so the other issue is already fixed or won't be fixed by this. Let me take a look at the other issue.

EDIT: I remember now, this one is to show that the issue reported there was actually solved, so I guess it makes sense if merging this will close #5566.

@keradus
Copy link
Member

keradus commented Apr 3, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 3484154 into PHP-CS-Fixer:2.18 Apr 3, 2021
@kubawerlos kubawerlos deleted the extend_priority_test_for_class_definition_vs_braces branch April 3, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style fixer for class is not backward-compatible
3 participants