bug #5567 Fix order of BracesFixer and ClassDefinitionFixer (Daeroni)

This PR was merged into the 2.18 branch.

Discussion
----------

Fix order of BracesFixer and ClassDefinitionFixer

If BracesFixer is configured with "position_after_functions_and_oop_constructs": "same", it would be overwritten by ClassDefinitionFixer putting the brace on the next line unless the ClassDefinitionFixer is run before BracesFixer.

It seems ClassDefinitionFixer was previously run implicitly before BracesFixer, but 701708e changed the priority of BracesFixer from negative to positive and the order of the two fixers were reversed.

Commits
-------

01d34da Fix order of BracesFixer and ClassDefinitionFixer

src/Fixer/Basic/BracesFixer.php

@@ -126,7 +126,7 @@ public function bar($baz)
      * {@inheritdoc}
      *
      * Must run before ArrayIndentationFixer, MethodArgumentSpaceFixer, MethodChainingIndentationFixer.
-     * Must run after ClassAttributesSeparationFixer, ElseifFixer, LineEndingFixer, MethodSeparationFixer, NoAlternativeSyntaxFixer, NoEmptyStatementFixer, NoUselessElseFixer, SingleSpaceAfterConstructFixer, SingleTraitInsertPerStatementFixer.
+     * Must run after ClassAttributesSeparationFixer, ClassDefinitionFixer, ElseifFixer, LineEndingFixer, MethodSeparationFixer, NoAlternativeSyntaxFixer, NoEmptyStatementFixer, NoUselessElseFixer, SingleSpaceAfterConstructFixer, SingleTraitInsertPerStatementFixer.
      */
     public function getPriority()
     {

src/Fixer/ClassNotation/ClassDefinitionFixer.php

@@ -97,6 +97,16 @@ interface Bar extends
         );
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * Must run before BracesFixer.
+     */
+    public function getPriority()
+    {
+        return 36;
+    }
+
     /**
      * {@inheritdoc}
      */

tests/AutoReview/FixerFactoryTest.php

@@ -76,6 +76,7 @@ public function provideFixersPriorityCases()
             [$fixers['braces'], $fixers['method_chaining_indentation']],
             [$fixers['class_attributes_separation'], $fixers['braces']],
             [$fixers['class_attributes_separation'], $fixers['indentation_type']],
+            [$fixers['class_definition'], $fixers['braces']],
             [$fixers['class_keyword_remove'], $fixers['no_unused_imports']],
             [$fixers['combine_consecutive_issets'], $fixers['multiline_whitespace_before_semicolons']],
             [$fixers['combine_consecutive_issets'], $fixers['no_singleline_whitespace_before_semicolons']],

tests/Fixtures/Integration/priority/class_definition,braces.test

@@ -0,0 +1,15 @@
+--TEST--
+Integration of fixers: class_definition,braces.
+--RULESET--
+{"class_definition": true, "braces": {"position_after_functions_and_oop_constructs": "same"}}
+--EXPECT--
+<?php
+
+class Foo {
+}
+
+--INPUT--
+<?php
+
+class Foo{
+}