ExtraEmptyLinesFixer bugfix #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meh. Seems like this is segfaulting again (not in the tests, but when running it on some code..) |
|
Ok. Seems to work fine for me now. Please test it on some large codebase before merging though. |
|
No segfault over here |
fabpot
added a commit
that referenced
this pull request
May 29, 2012
Commits ------- d881a84 Fix segfault f22dfc0 Fix ExtraEmptyLinesFixer regex for nowdocs and small cleanup of to_fix group 5102b4a Add failing test: if nowdoc contains { } or 1 the regex fails to match and strips extra lines Discussion ---------- ExtraEmptyLinesFixer bugfix There was an issue in heredocs/nowdocs containing {, } or 1. The regex wouldn't match and they weren't safe anymore. /cc @adrienbrault --------------------------------------------------------------------------- by Seldaek at 2012-05-28T14:14:14Z Meh. Seems like this is segfaulting again (not in the tests, but when running it on some code..) --------------------------------------------------------------------------- by Seldaek at 2012-05-28T14:37:40Z Ok. Seems to work fine for me now. Please test it on some large codebase before merging though. --------------------------------------------------------------------------- by adrienbrault at 2012-05-28T14:50:24Z No segfault over here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in heredocs/nowdocs containing {, } or 1. The regex wouldn't match and they weren't safe anymore.
/cc @adrienbrault