This repository has been archived by the owner on Feb 16, 2019. It is now read-only.
Fix parsing nullable types with php 7.1 #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2017 10:20
…o parse nullable types with php 7.1
fabpot
reviewed
Jan 31, 2017
Sami/Parser/NodeVisitor.php
Outdated
| } | ||
|
|
||
| if ($typeStr != null) { |
jakesylvestre
approved these changes
Mar 4, 2017
|
Any timeline on this being merged? |
|
Thank you @derFunk. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https://github.com/FriendsOfPHP/Sami/issues/264.
This fixes the exception which was preventing document generation.
The resulting docs which state e.g.
null|stringfor a nullable?string.