Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Commit

Permalink
minor #122 CS fixes (keradus)
Browse files Browse the repository at this point in the history
This PR was merged into the master branch.

Discussion
----------

CS fixes

Commits
-------

3003f27 CS fixes
  • Loading branch information
lyrixx committed Jan 19, 2015
2 parents 6868ce7 + 3003f27 commit 17a0064
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 9 deletions.
6 changes: 4 additions & 2 deletions src/Sismo/Contrib/CrossFingerNotifier.php
Expand Up @@ -48,7 +48,8 @@ public function __construct($notifiers = array())
/**
* Notifies a commit.
*
* @param Commit $commit Then Commit instance
* @param Commit $commit Then Commit instance
*
* @return bool whether notification has been sent or not
*/
public function notify(Commit $commit)
Expand All @@ -68,7 +69,8 @@ public function notify(Commit $commit)
* Determines if a build needs to be notify
* based on his status and his predecessor's one
*
* @param Commit $commit The commit to analyse
* @param Commit $commit The commit to analyse
*
* @return bool whether the commit need notification or not
*/
protected function commitNeedNotification(Commit $commit)
Expand Down
21 changes: 14 additions & 7 deletions src/Sismo/Contrib/GithubNotifier.php
Expand Up @@ -53,7 +53,8 @@ public function __construct($apikey, $repo, $targetUrlPattern = null)
}

/**
* @param string $context
* @param string $context
*
* @return $this
*/
public function setContext($context)
Expand All @@ -64,7 +65,8 @@ public function setContext($context)
}

/**
* @param string $description
* @param string $description
*
* @return $this
*/
public function setDescription($description)
Expand All @@ -75,7 +77,8 @@ public function setDescription($description)
}

/**
* @param string $host
* @param string $host
*
* @return $this
*/
public function setHost($host)
Expand All @@ -86,7 +89,8 @@ public function setHost($host)
}

/**
* @param string $targetUrlPattern
* @param string $targetUrlPattern
*
* @return $this
*/
public function setTargetUrlPattern($targetUrlPattern)
Expand Down Expand Up @@ -116,7 +120,8 @@ public function notify(Commit $commit)
}

/**
* @param Commit $commit
* @param Commit $commit
*
* @return string
*/
protected function getStatusEndpointUrl(Commit $commit)
Expand All @@ -125,7 +130,8 @@ protected function getStatusEndpointUrl(Commit $commit)
}

/**
* @param Commit $commit
* @param Commit $commit
*
* @return string
*/
protected function getGitHubState(Commit $commit)
Expand Down Expand Up @@ -156,7 +162,8 @@ protected function getGitHubHeaders()
/**
* @param $url
* @param $data
* @param array $headers
* @param array $headers
*
* @return bool
*/
protected function request($url, $data, array $headers = array())
Expand Down

0 comments on commit 17a0064

Please sign in to comment.