Skip to content

Commit

Permalink
Allow passing options without being a real file
Browse files Browse the repository at this point in the history
By removing the `is_file` check we allow installing extensions like this:

```bash
bin/pickle install --source --with-configure-options <(echo --with-rdkafka=/opt/homebrew/opt/librdkafka) rdkafka
```

No more need to create a file with the options first.
  • Loading branch information
ruudk committed Jul 29, 2021
1 parent eb4c247 commit 147511f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Base/Abstracts/Console/Command/BuildCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ protected function buildOptions(Package $package, InputInterface $input, OutputI
$force_opts = $input->getOption('with-configure-options');

if ($force_opts) {
if (!file_exists($force_opts) || !is_file($force_opts) || !is_readable($force_opts)) {
if (!file_exists($force_opts) || !is_readable($force_opts)) {
throw new Exception("File '{$force_opts}' is unusable");
}

Expand Down

0 comments on commit 147511f

Please sign in to comment.