simplesamlphp/saml2 SSPSA 201612-01: Incorrect signature validation #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the validator found some issues. |
… add-simplesamlphp-20161201 # Conflicts: # simplesamlphp/saml2/201612-01.yaml
fabpot
reviewed
Dec 3, 2016
| branches: | ||
| 1.9.x: | ||
| time: 2016-11-29 13:12:00 | ||
| versions: ['1.9.0', '<1.9.1'] |
There was a problem hiding this comment.
Amended my commit about five seconds later but you are a way to quick ;-)
|
Also, can you rebase to remove the merge commit? |
…ce package which is not provided by packagist
I was off by one in one situation and all of 2.5.x is vulnerable. Refs FriendsOfPHP#116
|
time to improve my phpstorm git client knowledge :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.