Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define package conflicts #55

Merged
merged 2 commits into from
Feb 19, 2017
Merged

define package conflicts #55

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc8ba8e
define package conflicts
schuer Feb 18, 2017
19145d1
add comment on conflicts definition
schuer Feb 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,11 @@ pages:

requires:
redaxo: '^5.0'
php: '>=5.5'
php: '>=5.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gharlan brauchts auch ne conflict rule für php >7 (da wir hier noch kein || können?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bei der PHP-Version scheint es üblicher zu sein, die Grenze doch nach oben offen zu lassen. Zumindest sehe ich das meist so in den composer.json's.
Ein Beispiel, Symfony: https://github.com/symfony/symfony/blob/master/composer.json#L19


conflicts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vllt solltest du hier nen kommentar reinmachen was diese regel bewirkt... conflict rules sind bisher in FOR nicht üblich

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, danke.

packages:
media_manager: '>=3'
metainfo: '>=3'
structure: '>=3'
yform: '>=3'