Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore node_modules folder #526

Merged
merged 1 commit into from Jun 24, 2023
Merged

ignore node_modules folder #526

merged 1 commit into from Jun 24, 2023

Conversation

eaCe
Copy link
Member

@eaCe eaCe commented Jun 24, 2023 •
edited by staabm

fix #523

@eaCe
Copy link
Member Author

eaCe commented Jun 24, 2023

fix #523

@staabm
Copy link
Member

staabm commented Jun 24, 2023

Hast die Änderung verifiziert ob sie das erreicht was du dir erhoft hast?

@eaCe
Copy link
Member Author

eaCe commented Jun 24, 2023 •
edited

Bei einem lokalen Test sah es gut aus.
Es ist auch eher die Ausnahme, aber bei mir liegt ein Module drin, das auch PHP Dateien beinhaltet.

@staabm staabm merged commit 29dfd6b into FriendsOfREDAXO:main Jun 24, 2023
5 checks passed
@staabm
Copy link
Member

staabm commented Jun 24, 2023

Danke

@staabm
Copy link
Member

staabm commented Jun 24, 2023

Interessant dabei ist vermutlich eher die performance verbesserung weil PHPStan nicht in den untiefen des node_modules Ordner nach PHP Dateien suchen muss

@staabm staabm mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude node_modules
2 participants
@eaCe @staabm