Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan vendor directories #587

Closed
wants to merge 1 commit into from
Closed

scan vendor directories #587

wants to merge 1 commit into from

Conversation

bloep
Copy link
Member

@bloep bloep commented Sep 23, 2023

we need to scan vendor folders to find externals e.g. phpunit to reduce false-positives

refs redaxo/redaxo#5629

refs #69

@bloep bloep requested a review from staabm September 23, 2023 11:59
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@staabm
Copy link
Member

staabm commented Sep 23, 2023

@bloep test erfolgreich?

@bloep
Copy link
Member Author

bloep commented Sep 23, 2023

@bloep test erfolgreich?

habs grad nochmal getestet und jetzt brauchte ich den change nicht.
auch das ergebnis in der action zeigt erstmal keine unknown classes fehler
https://github.com/redaxo/redaxo/actions/runs/6283396862/job/17063819450?pr=5629

@staabm was meinst du?

@staabm
Copy link
Member

staabm commented Sep 23, 2023

Die vendoren müsste via compose autoloader automatisch verfügbar sein

@staabm staabm closed this Sep 23, 2023
@staabm
Copy link
Member

staabm commented Sep 23, 2023

Wenns nicht gebraucht wird machen wir zuu

@staabm staabm deleted the scan-vendor branch September 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants