Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove subscriber generator #44

Merged
merged 1 commit into from
Nov 28, 2022
Merged

remove subscriber generator #44

merged 1 commit into from
Nov 28, 2022

Conversation

stefanpoensgen
Copy link
Member

@stefanpoensgen stefanpoensgen commented Nov 27, 2022

Since shopware 6.4.1 we can use a core event and get rid of some code

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Merging #44 (6f39ec5) into master (fe2b62e) will increase coverage by 2.91%.
The diff coverage is 56.25%.

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
+ Coverage     87.31%   90.23%   +2.91%     
+ Complexity      102       76      -26     
============================================
  Files            15       12       -3     
  Lines           276      215      -61     
============================================
- Hits            241      194      -47     
+ Misses           35       21      -14     
Impacted Files Coverage Δ
src/Subscriber/FlowSubscriber.php 71.42% <56.25%> (-10.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shyim shyim merged commit afad1ac into FriendsOfShopware:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants